KEDA Kafka Scaler : Not able to set activationLagThreshold to '0' value (which is default value supported by KEDA)

[chalokodekare]

Report

KEDA is supporting 0 as the default value for activationLagThreshold in kafka scaler. But if we set this field explicitly with the 0 value, KEDA is throwing below error:

"error":"error parsing kafka metadata: "activationLagThreshold" must be positive number"

A default should always behave the same whether you set it explicitly or leave it, if optional.

Expected Behavior

A default should always behave the same whether you set it explicitly or leave it, if optional.

So even if we set activationLagThreshold as 0, KEDA should not throw any error.

Actual Behavior

KEDA is throwing below error

"error":"error parsing kafka metadata: "activationLagThreshold" must be positive number"

Steps to Reproduce the Problem

1. Create a job/pod spec with kafka scaler
2. Set activationLagThreshold value to 0
3. Try to deploy the job/pod
4. Check keda operator logs

Logs from KEDA operator

example

KEDA Version

2.9.2

Kubernetes Version

1.26

Platform

Microsoft Azure

Scaler Details

Kafka Scaler

Anything else?

No response

[JorTurFer]

This makes sense totally, are you willing to fix it?

[chalokodekare]

@JorTurFer Yes, I would be glad to contribute. I'll raise a PR shortly. Can I get write access?

[JorTurFer]

@JorTurFer Yes, I would be glad to contribute. I'll raise a PR shortly. Can I get write access?

Nice! I assign this issue to you :)
Why do you need write access? For the PR, you have to fork this repo and do the changes in your own fork (where you have write access) and the, open the PR against this repo

[chalokodekare]

Thanks @JorTurFer

Raised the PR: #4143

[chalokodekare]

Thanks @JorTurFer

Will it be released as part of March 2nd, 2023 release? or can be released as part of some patch release? I'm new to KEDA release process and hence the question. :)

[JorTurFer]

I don't think that we do any other hotfix release before March (we have released v2.9.2 this week, and I'm releasing v2.8.2 right now), but for sure in the next minor release (v2.10 in March) will be included

[chalokodekare]

Hi @JorTurFer,

Can you please share the exact date when we'll be releasing v2.10?

Thanks,

[JorTurFer]

Hi @JorTurFer,

Can you please share the exact date when we'll be releasing v2.10?

Thanks,

We aim to do on 9th