Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Scaler - MongoDB Atlas connection string support #5544

Closed
lsteinberg-r7 opened this issue Feb 29, 2024 · 6 comments · Fixed by #5566
Closed

MongoDB Scaler - MongoDB Atlas connection string support #5544

lsteinberg-r7 opened this issue Feb 29, 2024 · 6 comments · Fixed by #5566
Assignees
Labels
good first issue Good for newcomers help wanted Looking for support from community

Comments

@lsteinberg-r7
Copy link

lsteinberg-r7 commented Feb 29, 2024

Proposal

In the current implementation (version 2.13.0), If we supply host & port instead of connectionString, it combines them under a hard-coded "mongodb" protocol -

image

I would like to request a support in MongoDB Atlas connection strings, that are supplied in the form of mongodb+srv://

Use-Case

Connecting to MongoDB Atlas instances.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@lsteinberg-r7 lsteinberg-r7 added feature-request All issues for new features that have not been committed to needs-discussion labels Feb 29, 2024
@JorTurFer
Copy link
Member

Hello!
This makes sense totally and IMO we can easily support it just adding another parameter for the protocol, with current value as default.

@JorTurFer JorTurFer added help wanted Looking for support from community good first issue Good for newcomers and removed needs-discussion feature-request All issues for new features that have not been committed to labels Feb 29, 2024
@tico88612
Copy link
Contributor

Hi @JorTurFer,

I am interested in this issue. Can you assign this issue to me?

@JorTurFer
Copy link
Member

Done! thanks @tico88612 !

@tico88612
Copy link
Contributor

Hi @JorTurFer,

I finished this PR. Should I need to edit keda-docs now? I'm trying to decide which version to edit.

@JorTurFer
Copy link
Member

Hi @JorTurFer,

I finished this PR. Should I need to edit keda-docs now? I'm trying to decide which version to edit.

yes, you have to modify the file for the next version (v2.14). In this case, this is the file: https://github.com/kedacore/keda-docs/blob/main/content/docs/2.14/scalers/mongodb.md

@tico88612
Copy link
Contributor

Hi @JorTurFer,
I finished this PR. Should I need to edit keda-docs now? I'm trying to decide which version to edit.

yes, you have to modify the file for the next version (v2.14). In this case, this is the file: https://github.com/kedacore/keda-docs/blob/main/content/docs/2.14/scalers/mongodb.md

Sure! Up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Looking for support from community
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants