Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables in IBM MQ scaler #6033

Closed
rickbrouwer opened this issue Aug 5, 2024 · 0 comments · Fixed by #6034
Closed

Remove unused variables in IBM MQ scaler #6033

rickbrouwer opened this issue Aug 5, 2024 · 0 comments · Fixed by #6034
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@rickbrouwer
Copy link
Contributor

rickbrouwer commented Aug 5, 2024

Proposal

This issue involves cleaning up the IBM MQ scaler code and ensuring the documentation is accurate.

The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code will be removed.

Additionally, the parameter tlsDisabled is used in the code in relation to CreateHTTPClient. However, all other scalers use the parameter unsafeSsl. To maintain consistency between other scalers, we are making changes, as unsafeSsl already handles this functionality. tls will still be supported. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead in version 2.18 and remove the deprecated code.

The current documentation states that the default queueDepth is 5, while the code default is 20. The documentation will be updated to reflect the correct default value of 20, aligning it with the code.

Finally, there will be some minor adjustments to the documentation.

Use-Case

You are required to specify a queueManager, while it is not used. That is unnecessary configuration.

tlsDisabled has never worked. The code looks at tls and it will be therefore always false, when you followed the documentation. But because the code now also contains unsafeSsl, we want to use this standard because other scalers use unsafeSsl for the same functionality.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Status: Ready To Ship
Development

Successfully merging a pull request may close this issue.

1 participant