Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inline autocomplete experience including disabling it #4029

Open
mRB0 opened this issue Dec 16, 2019 · 2 comments
Open

Improve inline autocomplete experience including disabling it #4029

mRB0 opened this issue Dec 16, 2019 · 2 comments

Comments

@mRB0
Copy link

mRB0 commented Dec 16, 2019

I am using KeePassXC 2.5.1 on MacOS 10.15.2.

Pull request 3300 added inline autocomplete while typing usernames. The linked discussion shows a screenshot with a setting to disable the functionality, but this seems to be missing.

I'd like to disable it because it interferes with my typing.

Specifically:

  • Typing a letter and then pressing backspace erases the completion instead of the letter I just typed (but only if there's a matching entry to complete to).

  • Entering a common initial substring will extend my input with undesired text, even if that text isn't supposed to be part of this entry (issue 3776).

Steps to reproduce

  1. Have an unrelated entry with the username johndoe
  2. Create a new entry.
  3. Type j<backspace>hawndoe.

Expected Behavior

Input field contains hawndoe

Current Behavior

Input field contains jhawndoe

I pressed backspace intending to erase the j, but it's still present.

Possible Solution

Option 1: Pull request 3300 demonstrated a setting to disable the behaviour, but this doesn't seem to be present in 2.5.1.

Option 2: Use a version prior to the feature's inclusion in 2.5.0.

Context

I type fast and use tactile feedback from my keyboard to confirm what I've typed. I'm often looking somewhere other than the input field while I'm typing, for example when I'm manually typing text that I'm reading from somewhere else (like on a paper form).

It's really frustrating to me when the software interprets my input in an unusual or surprising fashion, and it's important to me that my entries are precisely entered as typed.

Thanks in advance!

Debug Info

KeePassXC - Version 2.5.1
Revision: 0fd8836

Qt 5.13.1
Debugging mode is disabled.

Operating system: macOS 10.15
CPU architecture: x86_64
Kernel: darwin 19.2.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey
  • TouchID

Cryptographic libraries:
libgcrypt 1.8.5

@mRB0 mRB0 added the bug label Dec 16, 2019
@droidmonkey
Copy link
Member

droidmonkey commented Dec 16, 2019

The "undesired" backspace behavior you describe is the behavior of every autocomplete I've ever used. Chrome and Firefox both have this behavior in the address bar. I'm not against a setting to completely disable autocomplete, but your backspace proposal will not be implemented. It is essentially issuing two backspaces when one is pressed.

I personally prefer the Outlook style autocomplete for addresses. It only pops up a selection dialog below the field and does not append the completion to the typed text. That does cause a couple extra keyboard strokes to use though.

@mRB0
Copy link
Author

mRB0 commented Dec 16, 2019

Hi! Thanks for responding. I'm certainly not proposing that we should issue multiple backspaces; I was just using backspaces as an example of how the current behaviour interferes with typing. As you mention, the behaviour matches Firefox (where it can be disabled) and Chrome (where it cannot).

I'm suggesting that there should be an option to disable inline autocomplete altogether, or find another option that doesn't interfere with the user's typing (as you describe Outlook's behaviour).

@droidmonkey droidmonkey added this to the v2.6.0 milestone Jan 5, 2020
@droidmonkey droidmonkey changed the title Please offer an option to disable inline autocomplete Improve inline autocomplete experience Jan 5, 2020
@droidmonkey droidmonkey changed the title Improve inline autocomplete experience Improve inline autocomplete experience including disabling it Jan 5, 2020
@droidmonkey droidmonkey modified the milestones: v2.6.0, v2.7.0 May 30, 2020
@keepassxreboot keepassxreboot deleted a comment from hugodu69 Oct 12, 2021
@droidmonkey droidmonkey modified the milestones: v2.7.0, v2.7.1 Mar 21, 2022
@phoerious phoerious modified the milestones: v2.7.1, v2.7.2 Apr 12, 2022
@droidmonkey droidmonkey modified the milestones: v2.7.2, v2.8.0 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants