only:scope or only:(scope scope) not working

[gandm]

=scope works but only:scope doesn't. A modifier of only: is passed to the :matcherBuilder which thows an error Unknown modifier: only: at

atom-grammar-test/lib/matchers.js

Line 58 in d464ea7

throw Error(`Unknown modifier: ${modifier}`);

This is caught by

atom-grammar-test/lib/assertions.js

Line 75 in d464ea7

} catch (_e) {

which does nothing with it! No error is communicated to the user.

test file

// SYNTAX TEST "source.js.jsx"
/* this file contains all grammatical productions in ECMA-262 edition 5.1 ** * **/

// << =source.js.jsx
var a=2
//    ^ =(source.js.jsx constant.numeric.js)

// << only:source.js.jsx
var a=2
//    ^ only:(source.js.jsx constant.numeric.js)

[gandm]

Changing https://github.com/kevinastone/atom-grammar-test/blob/master/lib/grammar.pegjs#L34 to only = ("only:" / "=") { return "="; } fixes the returned modifier to be = but doesn't fix what to do with a valid thrown error,

[kevinastone]

Yeah, the no error to the user is an issue with this format since non-parsing comments are supposed to be ignored to allow other comments in the syntax test file 😐