-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to make bootstrap classes not disappear when removing a field from a row and putting it in an empty place #1575
Comments
Hi @giannicolac , thank you for your report. I can reproduce the form-control class bring dropped, will investigate why. row and col I cannot reproduce being dropped, they are recalculated when moving to a new row |
The loss of col and row doesn't seem to happen in the DOM, but when getting the data, such classes are gone in my case, even if they are in the DOM elements and the "class" in the panel has them. |
Please test out #1579, I've rewritten the syncFieldWithNewRow function which was corrupting the className string when dropped. |
I replaced my form-builder.js file in src/js with the one you changed, but it doesnt seem to have changed anything about the behavior. The form-control classes disappear, and row and col are not in the data. |
Hi @giannicolac did you ensure to rebuild after applying the patch? I've done additional refactoring this morning and also added Jest test cases plus manual testing. Classes are no longer being mangled |
Please try this patched version form-builder.min.js.gz |
This made it work, thank you. |
🎉 This issue has been resolved in version 3.19.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description:
Hello, i have a question. When i put two elements on a row, and then take one of them outside of it, it loses the bootstrap classes it had by default. I have enableEnhancedBootstrapGrid and enableColumnInsertMenu as true. I would like the elements to keep the classes after the process.
Environment Details:
Expected Behavior
For the elements to keep the classes when taken out of a row.
Actual Behavior
They lose the col, row and form-control classes
The text was updated successfully, but these errors were encountered: