syncFieldWithNewRow incorrectly replacing row values className attribute when element not current within row #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assName attribute
|
Original reporter confirms this resolves their issue |
kevinchappell
approved these changes
Jul 7, 2024
Comment on lines
+1479
to
+1490
| if (oldRow !== newRow) { | ||
| if (oldRow) { | ||
| currentClasses = currentClasses.filter(function(obj) { | ||
| return obj !== oldRow | ||
| }) | ||
| } | ||
| if (newRow) { | ||
| currentClasses.push(newRow) | ||
| } | ||
| inputClassElement.val(currentClasses.join(' ')) | ||
| } | ||
| } |
|
🎉 This PR is included in version 3.19.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1575
When drag + drop a field from one row to a new row the function syncFieldWithNewRow() is called 3 times, once in the sortable update: callback which removes the existing row, and again in receive: callback. On the second call the oldRow value is an empty string, which resulted in the replace() call having an empty pattern and corrupting the classString.
Reimplemented syncFieldWithNewRow by operating on the classNames as an array, handling the case where we drop onto the same row or no row value exists.
Additionally syncFieldWithNewRow has been moved into the Helpers class to ensure it is directly testable with Jest and secondly to ensure it only does one task (no checkRowCleanup() on each call, delayed checkRowCleanup() to sortable stop())