Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-1578 incorrect handling of label translation for custom controls #1580

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Fix GH-1578 incorrect handling of label translation for custom controls #1580

merged 4 commits into from
Jul 5, 2024

Conversation

lucasnetau
Copy link
Collaborator

@lucasnetau lucasnetau commented Jul 4, 2024 •
edited
Loading

Fixes #1578

A few issues here:

  • field.label wasn't translated when constructing the custom control label and icon map
  • custom control label and icon functions didn't reference the correct definition object
  • translated label wasn't read when constructing the control panel
  • translated label wasn't read when adding a field from the control panel to the stage

@lucasnetau lucasnetau mentioned this pull request Jul 4, 2024
Closed
@lucasnetau
Copy link
Collaborator Author

Original reported has tested PR and confirmed their issue is resolved. @kevinchappell should be good to merge

kevinchappell
kevinchappell approved these changes Jul 5, 2024
View reviewed changes
Copy link
Owner

@kevinchappell kevinchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work

@kevinchappell kevinchappell merged commit b24e2f6 into kevinchappell:master Jul 5, 2024
1 check passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🎉 This PR is included in version 3.19.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinchappell kevinchappell kevinchappell approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labels for fields and replaceFields options do not use localized strings
2 participants
@lucasnetau @kevinchappell