Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo upgrade: Don't change crate source #408

Closed
not-matthias opened this issue Jun 11, 2020 · 3 comments
Closed

cargo upgrade: Don't change crate source #408

not-matthias opened this issue Jun 11, 2020 · 3 comments

Comments

@not-matthias
Copy link

I have a custom log crate on my Github which is called log. However, there's also a public crate called log. So when I try to upgrade my dependencies with cargo upgrade, my own crate will be replaced with the one from crates.io.

How to reproduce

Create a log crate, upload it to a Github repository and add it to a project.

log = { git = "https://github.com/<username>/<repository>" }

If you now run cargo upgrade, the Cargo.toml will look like this:

log = "0.4.8"
@ordian
Copy link
Collaborator

ordian commented Jun 11, 2020

@not-matthias which version of cargo-edit do you use? This is resolved in the latest version.

@not-matthias
Copy link
Author

@ordian I'm using the latest version.

C:\>cargo upgrade --version
cargo-upgrade 0.6.0

@epage epage changed the title cargo upgrade: Upgrade to another crate cargo upgrade: Don't change crate source Mar 31, 2022
@epage
Copy link
Collaborator

epage commented Jul 13, 2022

If nothing else, this should be resolved by #725

@epage epage closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants