Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workspace inheritance in cargo-upgrade #751

Closed
Muscraft opened this issue Jul 26, 2022 · 1 comment · Fixed by #811
Closed

Support workspace inheritance in cargo-upgrade #751

Muscraft opened this issue Jul 26, 2022 · 1 comment · Fixed by #811

Comments

@Muscraft
Copy link

Muscraft commented Jul 26, 2022

Workspace inheritance was stabilized recently and set to be released in Rust version 1.64 on September 22, 2022.

cargo-upgrade currently does not update dependencies in the [workspace.dependencies] table. Support for this should be added as one of the main motivations for workspace inheritance was updating the dependency version in one place not every member of the workspace.

@epage
Copy link
Collaborator

epage commented Jul 27, 2022

Been thinking about what behavior we want

  • Touch workspace.dependencies when the full workspace is selected (e.g. --workspace)
  • Add a note: run with --workspace if workspace dependencies are used but workspace.dependencies aren't being upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants