Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --icmp-type and icmp6-type is missing #12

Closed
MEschenbacher opened this issue Feb 14, 2024 · 3 comments
Closed

Support for --icmp-type and icmp6-type is missing #12

MEschenbacher opened this issue Feb 14, 2024 · 3 comments

Comments

@MEschenbacher
Copy link
Contributor

The following lines

-A FORWARD -p ipv6-icmp -m icmp6 --icmpv6-type 1 -j ACCEPT
-A FORWARD -p icmp --icmp-type 0 -j ACCEPT

produce errors

Error: failed to parse line, skipping rest " --icmpv6-type 1 -j ACCEPT" of the line: match modules "icmp6" is not implemented
Error: failed to parse line, skipping rest " 0 -j ACCEPT" of the line: unknown flag "--icmp-type" found
@leonnicolas
Copy link
Collaborator

yes the extension icmp6 is not implemented, but contributions welcome of course.

-A FORWARD -p icmp --icmp-type 0 -j ACCEPT

is this missing a -m icmp6? Otherwise the flag --icmp-type shouldn't be allowed (at least to what I can see in the man pages of man iptables-extensions)

@MEschenbacher
Copy link
Contributor Author

The support for -p icmp6 is currently not very important, but just for the record.

The -A FORWARD -p icmp --icmp-type 0 -j ACCEPT should be allowed (and is currently deployed on hosts) according to my iptables-extensions(8)

   icmp (IPv4-specific)
       This extension can be used if `--protocol icmp' is specified. It provides the following option:

       [!] --icmp-type {type[/code]|typename}
              This  allows specification of the ICMP type, which can be a numeric ICMP type, type/code
              pair, or one of the ICMP type names shown by the command
               iptables -p icmp -h

@leonnicolas
Copy link
Collaborator

fixed with #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants