Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add penalty-threshold to annotation #75

Open
Shirkanesi opened this issue Apr 19, 2022 · 4 comments
Open

Feature: Add penalty-threshold to annotation #75

Shirkanesi opened this issue Apr 19, 2022 · 4 comments

Comments

@Shirkanesi
Copy link

Is your feature request related to a problem? Please describe.
The grading-tool allows to define a threshold after which points will get deduced (e.g. -1P when 3 annotations of same type are made). However this information is not properly visible in Artemis so in case a student starts a discussion about their deduction, instructors must keep track of the amount of such annotations made and then calculate the penalty.

Describe the solution you'd like
Display this information in the annotation.

@Shirkanesi
Copy link
Author

Due to the current design, actually getting information about the threshold is not that easy (as the actual ThresholdPenaltyRule cannot be accessed that easily from the AnnotationMapper).
I would suggest adding a String-Method "getPenaltyContext" (or similar) to PenaltyRule and use this output to put custom Strings in the annotations. (Basically the same concept as for the Tooltip-Text)
Not the most beautiful solution but more dynamic than trying to get to the actual ThresholdPenaltyRule at this point.

I've created a quick draft of this idea here Shirkanesi/programming-lecture-eclipse-artemis@345670e

Oppinions?

We might also discuss the actual formatting of this information, as using an entire line in the feedback looks weird, just putting (x/y) at the end of the headline of each penalty looks weird also :(

@dfuchss
Copy link
Member

dfuchss commented May 2, 2022

Due to the current design, actually getting information about the threshold is not that easy (as the actual ThresholdPenaltyRule cannot be accessed that easily from the AnnotationMapper).

Actually I'm not happy with the current state of the serialization at all ; therefore, I'll have a look at this part when I find some time :)
If you already have some idea how to make this better, feel free to create a proposal or write me a PM :)

@dfuchss dfuchss changed the title Feature: Add penalty-thresholt to annotation Feature: Add penalty-threshold to annotation Nov 29, 2022
@dfuchss dfuchss transferred this issue from kit-sdq/programming-lecture-eclipse-artemis Jul 14, 2024
@dfuchss
Copy link
Member

dfuchss commented Jul 14, 2024

@Feuermagier @Luro02 We can check whether we can include that to the new version of artemis4j or a follow-up PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants