Issue 96 improved exception handling #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable calling ExceptionDescribe, as this pollutes stderr, making it harder to implement clean exception handling. JNI documentation describes it as being for debugging purposes. - Extract separate fields for the exception class name, exception message, and exception stack trace, and add these as attributes to JavaException. Calling code can now decide for itself whether and how to present this information.
tito
added a commit
that referenced
this pull request
Mar 12, 2015
Issue 96 improved exception handling
|
I didn't saw this PR, someone just pointed it in the mailing list. Great job!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially applied just the patch that is described in #96, but then wanted to go further -- primarily so that on the python side I can distinguish between exception types and decide whether to locally handle the exception or whether to propagate the exception up (perhaps with exception rewrapping).