Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme to counter issues #197 #202

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Conversation

jk1ng
Copy link

@jk1ng jk1ng commented Feb 9, 2016

Readme.md now tells users to ensure that their PATH and JAVA_HOME (or JDK_HOME) environment variables must be set properly in order to ensure the successful usage of PyJNIus. This should help counter issues #197 -- not the most automated fix, but still.

Apologies for the triple commit, apparently I don't know how to use markdown properly :)

@jk1ng jk1ng changed the title Updated readme to counter issues #197 and #199 Updated readme to counter issues #197 Feb 9, 2016
@jk1ng
Copy link
Author

jk1ng commented Feb 9, 2016

As an addendum, this doesn't solve #199 -- danielepantaleone's PR #200 does that.

@danielepantaleone
Copy link
Contributor

You should squash all those commits together to keep a clean git history.
Also I think the problem should be addressed at a certain point. I had the very same problem in the application I'm using PyJNIus in and I have added some code to automatically lookup the JVM path on different operating systems in case the JAVA_HOME and Path variables are not setup correctly. Something similar to what JPype is doing....not a very clean approach imho, but it would be better than nothing.

akshayaurora added a commit that referenced this pull request Mar 10, 2016
Updated readme to counter issues #197
@akshayaurora akshayaurora merged commit e2f6b7b into kivy:master Mar 10, 2016
@akshayaurora
Copy link
Member

@jk1ng thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants