From f83c0ee3f57758e91ecee59b892b940a4933d782 Mon Sep 17 00:00:00 2001 From: Matej Vasek Date: Thu, 12 Oct 2023 14:24:35 +0200 Subject: [PATCH] fix s2i on cluster RT tests (#2015) * chore: use smaller s2i nodejs builder Signed-off-by: Matej Vasek * test: skip python s2i on cluster build test on GH Signed-off-by: Matej Vasek * fixup: do check at correct place Signed-off-by: Matej Vasek --------- Signed-off-by: Matej Vasek --- pkg/builders/s2i/builder.go | 2 +- test/oncluster/scenario_runtime_test.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/builders/s2i/builder.go b/pkg/builders/s2i/builder.go index edd70f691a..cc58811b55 100644 --- a/pkg/builders/s2i/builder.go +++ b/pkg/builders/s2i/builder.go @@ -36,7 +36,7 @@ import ( // DefaultName when no WithName option is provided to NewBuilder const DefaultName = builders.S2I -var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16" +var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16-minimal" var DefaultQuarkusBuilder = "registry.access.redhat.com/ubi8/openjdk-17" var DefaultPythonBuilder = "registry.access.redhat.com/ubi8/python-39" diff --git a/test/oncluster/scenario_runtime_test.go b/test/oncluster/scenario_runtime_test.go index da270add48..7d235abaeb 100644 --- a/test/oncluster/scenario_runtime_test.go +++ b/test/oncluster/scenario_runtime_test.go @@ -45,6 +45,9 @@ func TestRuntime(t *testing.T) { for _, builder := range runtimeSupportMap[lang] { if targetBuilder == "" || builder == targetBuilder { t.Run(fmt.Sprintf("%v_%v_test", lang, builder), func(t *testing.T) { + if lang == "python" && os.Getenv("GITHUB_ACTIONS") == "true" { + t.Skip("skipping python test in GH action because of space requirement") + } runtimeImpl(t, lang, builder) }) }