Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run commands through /usr/bin/env sh -c instead of $SHELL -c #85

Open
dominiklohmann opened this issue Jun 10, 2019 · 6 comments
Open
Labels

Comments

@dominiklohmann
Copy link

Run commands through /usr/bin/env sh -c instead of $SHELL -c.

This is directly related to koekeishiya/yabai#34 and also serves as future-proofing for macOS 10.15, where /bin/zsh will be the default shell instead of /bin/bash. Having consistency between skhd and yabai is definitely desirable.

This might be a breaking change for people that run launchctl setenv SHELL "/path/to/custom/shell" to change the shell for launchctl only, which seems worth discussing. Similar options have been discussed as part of #42.

@basbebe
Copy link

basbebe commented Jul 1, 2021

this would also make configs more portable. a config written for fish will not work with zsh and vice versa.
I use fish and I would very much like the possibility to set a default shell in the config to have it portable should I switch login shell in the future.

@basbebe
Copy link

basbebe commented Jul 3, 2021

another reason for using sh by default:
https://github.com/stephen-huan/dotfiles/blob/master/doc/skhd.md
long delays – as already discussed in this repo.

@ariel-frischer
Copy link

It seems like Im having issues running skhd inside bash, or anywhere due to this issue. Fish is my default shell.

fish: Command substitutions not allowed
yabai -m window --swap east || $(yabai -m window --display east; yabai -m display --focus east)

Is there some configuration quickfix?

@basbebe
Copy link

basbebe commented Apr 16, 2022

Is there some configuration quickfix?

@ariel-frischer I guess this is what you are looking for:

#42 (comment)

(use brew edit to have skhd use bash (or dash) instead of the user shell)

@luisbc92
Copy link

This fix should be implemented in the formula. I was about to give up on yabai because of the lag.

@pencilcheck
Copy link

Not sure why this isn't part of the launchagent, someone probably should make a PR to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants