Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InModernStandby should not persist across launcher restarts #1718

Closed
zackattack01 opened this issue May 16, 2024 · 0 comments · Fixed by #1719
Closed

InModernStandby should not persist across launcher restarts #1718

zackattack01 opened this issue May 16, 2024 · 0 comments · Fixed by #1719

Comments

@zackattack01
Copy link
Contributor

We currently cache a boolean flag (InModernStandby) for windows devices to expose the power state through knapsack. If the device shuts down from an InModernStandby state, that value will be cached within bbolt and read after boot.

This will happen before the power_event_subscriber could possibly be aware of the new state changes, and leave launcher out of sync with the device state. We use this state to pivot restart/healthcheck behavior for the desktop process (amongst other things), which can result in us skipping the MBA initialization entirely on boot.

One quick and easy way to avoid this would be to clear the cached state on launcher startup, assuming we are not being started from a sleeping state and giving the power_event_subscriber a chance to get us back in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant