Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kolide_system_profiler should not support an all option #1876

Open
directionless opened this issue Oct 2, 2024 · 0 comments
Open

kolide_system_profiler should not support an all option #1876

directionless opened this issue Oct 2, 2024 · 0 comments
Labels
component:table Table Changes good-first-issue

Comments

@directionless
Copy link
Contributor

Chatting with some coworkers, I learned that SELECT * FROM kolide_system_profiler where datatype like "%" works. But it returns so much data it crashes Terminal.app and probably has a bunch of gnarly load.

I think we should disable it. We should require a reasonable argument for datatype

launcher/ee/tables/systemprofiler/systemprofiler.go

Line 111 in 1ec19cd

// If the constraint is the magic "%", it's eqivlent to an `all` style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:table Table Changes good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@directionless