Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blocks to Toggle only works for first Toggle #223

Closed
MrDigii opened this issue Oct 27, 2023 · 7 comments
Closed

Adding blocks to Toggle only works for first Toggle #223

MrDigii opened this issue Oct 27, 2023 · 7 comments
Labels
🐞 Bug Something isn't working ⛑ Needs triage Someone is checking

Comments

@MrDigii
Copy link

MrDigii commented Oct 27, 2023

Description

If I add a Toggle block I can add multiple following blocks to the toggle as desired. If I add another Toggle block I only can add on block to it. All others are not recognized as a part of the Toggle block.

Environment

  • Editor.js version: 2.28.0

  • Plugins you use with their versions:

    • @editorjs/nested-list: 1.3.0
    • @editorjs/header: 2.7.0
  • Device, Browser, OS: MacBook Pro M2, Chrome, Mac OS

Current behavior

If I add a Toggle block I can add multiple following blocks to the toggle as desired. If I add another Toggle block I only can add on block to it. All others are not recognized as a part of the Toggle block.

Expected behavior

No matter how many toggles are used, blocks can always be assigned to them.

Additional context

editorjs-toggle-block version 0.3.14

@MrDigii MrDigii added ⛑ Needs triage Someone is checking 🐞 Bug Something isn't working labels Oct 27, 2023
@MarioRodriguezS
Copy link
Contributor

@MrDigii Thanks a lot for reporting the issue. We have been trying to reproduce the issue but with no success, Could you please provide more context or share a code sandbox with the error?

When I try to add several toggle blocks with the given dependencies versions:

Screenshot 2023-10-27 at 11 12 46 AM

@MrDigii
Copy link
Author

MrDigii commented Oct 27, 2023

@MarioRodriguezS Thank you for your fast response and effort.

I made a simple CodeSandbox to demonstrate the setup:
CodeSandbox

To show the problem I also made a GIF:
editorjs-bug

Thank's for your help :)

@balex25
Copy link

balex25 commented Nov 21, 2023

You have to press the 'Tab' button on blocks that want to move inside a toggle container.

@MrDigii
Copy link
Author

MrDigii commented Nov 28, 2023

You have to press the 'Tab' button on blocks that want to move inside a toggle container.

I my tests the 'Tab' button functionality is not reliable. Sometimes the block automatically belongs to the toggle sometimes not. Also the different block types can interfere because they also use the same keybinding to display their own settings.

So it's not very intuitive to use in my opinion. But maybe I missed something?

@miguelnietoa
Copy link
Member

@MrDigii, thank you for reporting this. As you showed, currently, the toggle block plugin encounters limitations in handling List support effectively. We'll keep you informed of any developments on this matter.

@miguelnietoa
Copy link
Member

@MrDigii @balex25, we're excited to announce the release of version 0.3.16, addressing the reported issue. Kindly review it and confirm that the fix resolves the issue for you. Thanks!

@juliandsg0222 juliandsg0222 removed their assignment Apr 25, 2024
@juliandsg0222 juliandsg0222 removed the 📍 Work in progress Current work in progress label Apr 25, 2024
@MrDigii
Copy link
Author

MrDigii commented May 6, 2024

@MrDigii @balex25, we're excited to announce the release of version 0.3.16, addressing the reported issue. Kindly review it and confirm that the fix resolves the issue for you. Thanks!

I tested it in my application and it looks good now. Thanks for your effort @miguelnietoa and team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working ⛑ Needs triage Someone is checking
Projects
None yet
Development

No branches or pull requests

6 participants