Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Kantra to integrate with the new provider #5

Open
mansam opened this issue Jan 25, 2024 · 2 comments
Open

Prepare Kantra to integrate with the new provider #5

mansam opened this issue Jan 25, 2024 · 2 comments
Assignees

Comments

@mansam
Copy link
Collaborator

mansam commented Jan 25, 2024

This provider has different needs from the Java provider, in that rather than a source directory or a binary it requires coordinates to a cluster and a set of namespaces and GroupVersionKinds to analyze. I assume we'll need to add a new CLI command and some machinery to pass along these parameters, plus whatever might need to be done to talk to a provider that isn't the Java one. We could probably get away with adding a k8s specific command, but we should probably keep general platform awareness in mind.

@eemcmullan
Copy link
Collaborator

We could add a new kantra subcommand such as kantra k8s-analyze (not set on that name) so that we can easily pass these parameters without running analyzer-lsp. We will need the Dockerfile first to run this as a container.

Also, kantra and analyzer-lsp use cobra https://github.com/spf13/cobra to implement the cli. It may be worth considering using that as well with the k8s-provider.

@mansam
Copy link
Collaborator Author

mansam commented Jan 29, 2024

That plan makes sense to me, as does the suggestion to use cobra for the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants