Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DifferentiableFunction DotProduct has repeated code segments #68

Open
kostaleonard opened this issue Jan 31, 2023 · 0 comments
Open

DifferentiableFunction DotProduct has repeated code segments #68

kostaleonard opened this issue Jan 31, 2023 · 0 comments
Assignees
@kostaleonard
Labels
enhancement New feature or request
Milestone
First release

Comments

@kostaleonard
Copy link
Owner

As a contributor, I want DotProduct to not repeat code so that the interfaces are more readable and maintainable. DotProduct's (vectorInnerProductGradient, getVectorInnerProductShapeWithPlaceholders) and (matmulGradient, getMatMulShapeWithPlaceholders) have repeated code segments that we should address.
@kostaleonard kostaleonard added the enhancement New feature or request label Jan 31, 2023
@kostaleonard kostaleonard added this to the First release milestone Jan 31, 2023
@kostaleonard kostaleonard self-assigned this Jan 31, 2023
@kostaleonard kostaleonard changed the title DotProduct's (vectorInnerProductGradient, getVectorInnerProductShapeWithPlaceholders) and (matmulGradient, getMatMulShapeWithPlaceholders) have repeated code segments DifferentiableFunction DotProduct has repeated code segments Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostaleonard kostaleonard

Labels
enhancement New feature or request
Projects
None yet
Milestone
First release
Development

No branches or pull requests
1 participant
@kostaleonard