From 89e1837b674a63a0c26761ef97ba9fa33f327eee Mon Sep 17 00:00:00 2001 From: msvinaykumar Date: Mon, 22 May 2023 18:21:15 +0530 Subject: [PATCH] NoResultException added. Signed-off-by: msvinaykumar --- .../java/com/autotune/database/dao/ExperimentDAOImpl.java | 4 ++++ .../autotune/database/service/ExperimentDBService.java | 8 +++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/autotune/database/dao/ExperimentDAOImpl.java b/src/main/java/com/autotune/database/dao/ExperimentDAOImpl.java index 5a506bb4b..c089caf7c 100644 --- a/src/main/java/com/autotune/database/dao/ExperimentDAOImpl.java +++ b/src/main/java/com/autotune/database/dao/ExperimentDAOImpl.java @@ -9,6 +9,7 @@ import com.autotune.database.table.KruizeRecommendationEntry; import com.autotune.database.table.KruizeResultsEntry; import com.autotune.utils.KruizeConstants; +import jakarta.persistence.NoResultException; import org.hibernate.HibernateException; import org.hibernate.Session; import org.hibernate.Transaction; @@ -252,6 +253,9 @@ public KruizeResultsEntry getKruizeResultsEntry(String experiment_name, Timestam .setParameter(KruizeConstants.JSONKeys.EXPERIMENT_NAME, experiment_name) .setParameter(KruizeConstants.JSONKeys.INTERVAL_END_TIME, interval_end_time) .getSingleResult(); + } catch (NoResultException e) { + LOGGER.error("Data not found in kruizeResultsEntry for exp_name:{} interval_end_time:{} ", experiment_name, interval_end_time); + kruizeResultsEntry = null; } catch (Exception e) { kruizeResultsEntry = null; LOGGER.error("Not able to load results due to: {}", e.getMessage()); diff --git a/src/main/java/com/autotune/database/service/ExperimentDBService.java b/src/main/java/com/autotune/database/service/ExperimentDBService.java index 0a0e59a69..4c72d222e 100644 --- a/src/main/java/com/autotune/database/service/ExperimentDBService.java +++ b/src/main/java/com/autotune/database/service/ExperimentDBService.java @@ -294,9 +294,11 @@ public boolean updateExperimentStatus(KruizeObject kruizeObject, AnalyzerConstan public ExperimentResultData getExperimentResultData(String experiment_name, Timestamp interval_end_time) throws Exception { ExperimentResultData experimentResultData = null; KruizeResultsEntry kruizeResultsEntry = experimentDAO.getKruizeResultsEntry(experiment_name, interval_end_time); - List updateResultsAPIObjects = DBHelpers.Converters.KruizeObjectConverters.convertResultEntryToUpdateResultsAPIObject(Collections.singletonList(kruizeResultsEntry)); - if (null != updateResultsAPIObjects && !updateResultsAPIObjects.isEmpty()) { - experimentResultData = Converters.KruizeObjectConverters.convertUpdateResultsAPIObjToExperimentResultData(updateResultsAPIObjects.get(0)); + if (null != kruizeResultsEntry) { + List updateResultsAPIObjects = DBHelpers.Converters.KruizeObjectConverters.convertResultEntryToUpdateResultsAPIObject(Collections.singletonList(kruizeResultsEntry)); + if (null != updateResultsAPIObjects && !updateResultsAPIObjects.isEmpty()) { + experimentResultData = Converters.KruizeObjectConverters.convertUpdateResultsAPIObjToExperimentResultData(updateResultsAPIObjects.get(0)); + } } return experimentResultData; }