From 3d68702d9b2a666b15c0d72e427db8af62dc9625 Mon Sep 17 00:00:00 2001
From: johncurrier <johncurrier@e86a8a9b-1e1f-0410-8769-81452b7583c3>
Date: Fri, 6 May 2011 21:31:43 +0000
Subject: [PATCH] Removed "null" default value anomaly due to the inability to
 accurately detect it.

---
 dist/releaseNotes.html                        |  8 ++++++
 pom.xml                                       |  2 ++
 .../net/sourceforge/schemaspy/DbAnalyzer.java | 25 -------------------
 .../schemaspy/view/HtmlAnomaliesPage.java     |  8 ------
 4 files changed, 10 insertions(+), 33 deletions(-)

diff --git a/dist/releaseNotes.html b/dist/releaseNotes.html
index 79df46c..a40d312 100644
--- a/dist/releaseNotes.html
+++ b/dist/releaseNotes.html
@@ -14,6 +14,14 @@ <h3><a href='http://schemaspy.sourceforge.net'>SchemaSpy</a> Release Notes</h3>
 
 <li class='release'>x.x.x - xx/xx/xxxx - Subversion revision xxx
 <ul>
+    <li>Resolved <a href="https://sourceforge.net/tracker/index.php?func=detail&aid=2965546&group_id=137197&atid=737987">
+        bug 2965546</a> - Oracle DEFAULT NULL anomaly.<br>
+        Unfortunately I was unable to determine a mechanism for detecting the null-handling
+        change in behavior between various versions of JDBC (or the drivers?  or the databases?),
+        so I had to remove the detection of the anomaly. 
+        rev 644<br>
+        Thanks to Vladimir Vilinski for reporting the issue.
+    </li>
     <li>Resolved <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=3296973&group_id=137197&atid=737987">
         bug 3296973</a> - Tables not included with -i appears in relationship tab<br>
         rev 643<br>
diff --git a/pom.xml b/pom.xml
index 02c284f..b931c0c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -61,6 +61,8 @@
         <configuration>
           <source>1.5</source>
           <target>1.5</target>
+          <debug>true</debug>
+          <debuglevel>source,lines</debuglevel>
         </configuration>
       </plugin>
       <plugin>
diff --git a/src/main/java/net/sourceforge/schemaspy/DbAnalyzer.java b/src/main/java/net/sourceforge/schemaspy/DbAnalyzer.java
index 650a3a9..93dd9af 100644
--- a/src/main/java/net/sourceforge/schemaspy/DbAnalyzer.java
+++ b/src/main/java/net/sourceforge/schemaspy/DbAnalyzer.java
@@ -282,31 +282,6 @@ public int compare(TableColumn column1, TableColumn column2) {
         return columns;
     }
 
-    /**
-     * Returns a list of columns that have the word "NULL" or "null" as their default value
-     * instead of the likely candidate value null.
-     *
-     * @param tables Collection
-     * @return List
-     */
-    public static List<TableColumn> getDefaultNullStringColumns(Collection<Table> tables) {
-        List<TableColumn> defaultNullStringColumns = new ArrayList<TableColumn>();
-
-        for (Table table : tables) {
-            for (TableColumn column : table.getColumns()) {
-                Object defaultValue = column.getDefaultValue();
-                if (defaultValue != null && defaultValue instanceof String) {
-                    String defaultString = defaultValue.toString();
-                    if (defaultString.trim().equalsIgnoreCase("null")) {
-                        defaultNullStringColumns.add(column);
-                    }
-                }
-            }
-        }
-
-        return sortColumnsByTable(defaultNullStringColumns);
-    }
-
     /**
      * getSchemas - returns a List of catalog names (Strings)
      *
diff --git a/src/main/java/net/sourceforge/schemaspy/view/HtmlAnomaliesPage.java b/src/main/java/net/sourceforge/schemaspy/view/HtmlAnomaliesPage.java
index 7faac2c..ea2a57a 100755
--- a/src/main/java/net/sourceforge/schemaspy/view/HtmlAnomaliesPage.java
+++ b/src/main/java/net/sourceforge/schemaspy/view/HtmlAnomaliesPage.java
@@ -61,7 +61,6 @@ public void write(Database database, Collection<Table> tables, List<? extends Fo
         writeUniqueNullables(DbAnalyzer.getMustBeUniqueNullableColumns(new HashSet<Table>(tables)), out);
         writeTablesWithOneColumn(DbAnalyzer.getTablesWithOneColumn(tables), out);
         writeTablesWithIncrementingColumnNames(DbAnalyzer.getTablesWithIncrementingColumnNames(tables), out);
-        writeDefaultNullStrings(DbAnalyzer.getDefaultNullStringColumns(new HashSet<Table>(tables)), out);
         writeFooter(out);
     }
 
@@ -253,13 +252,6 @@ private void writeTablesWithOneColumn(List<Table> tables, LineWriter out) throws
         out.writeln("<p></li>");
     }
 
-    private void writeDefaultNullStrings(List<TableColumn> uniqueNullables, LineWriter out) throws IOException {
-        out.writeln("<li>");
-        out.writeln("<b>Columns whose default value is the word 'NULL' or 'null', but the SQL NULL value may have been intended:</b>");
-        writeColumnBasedAnomaly(uniqueNullables, out);
-        out.writeln("<p></li>");
-    }
-
     private void writeColumnBasedAnomaly(List<TableColumn> columns, LineWriter out) throws IOException {
         if (!columns.isEmpty()) {
             out.writeln("<table class='dataTable' border='1' rules='groups'>");