From 83e36dd08d7bc52425266b4b4c74bca1936f8da7 Mon Sep 17 00:00:00 2001
From: kirillzyusko <kiryl@margelo.io>
Date: Fri, 2 Aug 2024 17:20:10 +0200
Subject: [PATCH] e2e: add `lowerIsBetter` for e2e metrics

---
 tests/e2e/compare/compare.ts | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tests/e2e/compare/compare.ts b/tests/e2e/compare/compare.ts
index 8c7d95f72cb6..40a728545668 100644
--- a/tests/e2e/compare/compare.ts
+++ b/tests/e2e/compare/compare.ts
@@ -29,6 +29,15 @@ const PROBABILITY_CONSIDERED_SIGNIFICANCE = 0.02;
  */
 const DURATION_DIFF_THRESHOLD_SIGNIFICANCE = 100;
 
+const LowerIsBetter: Record<Unit, boolean> = {
+    ms: true,
+    MB: true,
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    '%': true,
+    renders: true,
+    FPS: false,
+};
+
 function buildCompareEntry(name: string, compare: Stats, baseline: Stats, unit: Unit): Entry {
     const diff = compare.mean - baseline.mean;
     const relativeDurationDiff = diff / baseline.mean;
@@ -44,7 +53,7 @@ function buildCompareEntry(name: string, compare: Stats, baseline: Stats, unit:
         baseline,
         current: compare,
         diff,
-        relativeDurationDiff,
+        relativeDurationDiff: LowerIsBetter[unit] ? relativeDurationDiff : -relativeDurationDiff,
         isDurationDiffOfSignificance,
     };
 }