diff --git a/FAQ.md b/FAQ.md index e84bde465..6fac4d36c 100644 --- a/FAQ.md +++ b/FAQ.md @@ -35,7 +35,7 @@ What you can do in this case is either install a storage class that enables 1. Retrieve the `.py` file generated by Kale (it should be next to the `.ipynb`) 2. Search for `marshal_vop` definition (`marshal_vop = dsl.VolumeOp...`) -3. Change this line `modes=dsl.VOLUME_MODE_RWM`, to `modes=dsl.VOLUME_MODE_RWO` +3. Change this line `modes=['ReadWriteMany']`, to `modes=['ReadWriteOnce']` 4. Run the `.py` file ### Data passing and pickle errors diff --git a/backend/kale/config/validators.py b/backend/kale/config/validators.py index 06c19cf1a..c67ce5024 100644 --- a/backend/kale/config/validators.py +++ b/backend/kale/config/validators.py @@ -195,7 +195,7 @@ class VolumeTypeValidator(EnumValidator): class VolumeAccessModeValidator(EnumValidator): """Validates the access mode of a Volume.""" - enum = ("", "rom", "rwo", "rwm") + enum = ("", "rox", "rwo", "rwx") class IsLowerValidator(Validator): diff --git a/backend/kale/pipeline.py b/backend/kale/pipeline.py index 010e22c5a..249878ab9 100644 --- a/backend/kale/pipeline.py +++ b/backend/kale/pipeline.py @@ -27,9 +27,9 @@ log = logging.getLogger(__name__) -VOLUME_ACCESS_MODE_MAP = {"rom": ["ReadOnlyMany"], "rwo": ["ReadWriteOnce"], - "rwm": ["ReadWriteMany"]} -DEFAULT_VOLUME_ACCESS_MODE = VOLUME_ACCESS_MODE_MAP["rwm"] +VOLUME_ACCESS_MODE_MAP = {"rox": ["ReadOnlyMany"], "rwo": ["ReadWriteOnce"], + "rwx": ["ReadWriteMany"]} +DEFAULT_VOLUME_ACCESS_MODE = VOLUME_ACCESS_MODE_MAP["rwx"] class PipelineParam(NamedTuple): diff --git a/labextension/src/components/VolumeAccessModeSelect.tsx b/labextension/src/components/VolumeAccessModeSelect.tsx index 71057bab5..e4376c277 100644 --- a/labextension/src/components/VolumeAccessModeSelect.tsx +++ b/labextension/src/components/VolumeAccessModeSelect.tsx @@ -17,22 +17,22 @@ import * as React from 'react'; import { Select, ISelectOption } from './Select'; -const VOLUME_ACCESS_MODE_ROM: ISelectOption = { +const VOLUME_ACCESS_MODE_ROX: ISelectOption = { label: 'ReadOnlyMany', - value: 'rom', + value: 'rox', }; const VOLUME_ACCESS_MODE_RWO: ISelectOption = { label: 'ReadWriteOnce', value: 'rwo', }; -const VOLUME_ACCESS_MODE_RWM: ISelectOption = { +const VOLUME_ACCESS_MODE_RWX: ISelectOption = { label: 'ReadWriteMany', - value: 'rwm', + value: 'rwx', }; const VOLUME_ACCESS_MODES: ISelectOption[] = [ - VOLUME_ACCESS_MODE_ROM, + VOLUME_ACCESS_MODE_ROX, VOLUME_ACCESS_MODE_RWO, - VOLUME_ACCESS_MODE_RWM, + VOLUME_ACCESS_MODE_RWX, ]; interface VolumeAccessModeSelectProps { diff --git a/labextension/src/widgets/LeftPanel.tsx b/labextension/src/widgets/LeftPanel.tsx index ca9fb34f8..baa8a9802 100644 --- a/labextension/src/widgets/LeftPanel.tsx +++ b/labextension/src/widgets/LeftPanel.tsx @@ -193,7 +193,7 @@ export const DefaultState: IState = { autosnapshot: false, katib_run: false, steps_defaults: [], - volume_access_mode: 'rwm', + volume_access_mode: 'rwx', }, runDeployment: false, deploymentType: 'compile',