-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating chart content without incrementing the version #711
Comments
@woehrl01 that's intended, mainly for fixing the CVEs in sidecar containers. |
@andyzhangx I see, but shouldn't a change, even for CVEs, result in a version increment? |
I'm unable to use the newer chart version since this images doesn't exist: $ docker pull registry.k8s.io/sig-storage/nfsplugin:v4.8.0
Error response from daemon: manifest for registry.k8s.io/sig-storage/nfsplugin:v4.8.0 not found: manifest unknown: Failed to fetch "v4.8.0"
The version is pinned here: csi-driver-nfs/charts/v4.8.0/csi-driver-nfs/values.yaml Lines 5 to 6 in a3ffafe
|
@Skaronator see #589 |
Ah okay thanks. Only looked at recent issues. I'm just gonna add a 4 hour delay to renovate for this helm chart :) |
100% agreed. Pretty much every other chart I've ever seen increments it's patch version for image patching. It's very important in any kind of environment that has strict change control not to introduce spontaneous changes without a change in config (kind of the whole point of infrastructure-as-code). |
What happened:
The following commit updated the chart content without incrementing the version tag. I'm not sure if this is intended but this leads to updating all helm deployments to that content without noticing directly.
30c0f8f
What you expected to happen:
If a new version gets released, the version should be incremented. Older versions should not be changed.
How to reproduce it:
Anything else we need to know?:
Environment:
kubectl version
):uname -a
):The text was updated successfully, but these errors were encountered: