Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Make retry and timeout args configurable #1579

Closed
samuel-trautwein opened this issue Apr 20, 2023 · 0 comments · Fixed by #1627
Closed

Helm: Make retry and timeout args configurable #1579

samuel-trautwein opened this issue Apr 20, 2023 · 0 comments · Fixed by #1627
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@samuel-trautwein
Copy link

samuel-trautwein commented Apr 20, 2023

Is your feature request related to a problem? Please describe.

We need to configure the --retry-interval-start, --retry-interval-max and --timeout parameters on the csi-provisioner and csi-attacher containers for dealing gracefully with EC2 throttling exceptions, when running batch jobs which provision large amounts of dynamically created PVCs in a short time frame.

Those runtime args are currently not configurable through the helm chart and must be configured manually.

Describe the solution you'd like in detail
Make those runtime parameters configurable through the values.yaml on the helm chart.

This can be done either through a generic additional_args configurations for those containers in the values.yml:

sidecars:
  provisioner:
    ...
    additional_args:
    - --retry-interval-start=1s
    - --retry-interval-max=5m
    - --timeout=15s
    ...

  attacher:
    ...
    additional_args:
    - --retry-interval-start=1s
    - --retry-interval-max=5m
    - --timeout=15s
    ...

Or alternatively through explicit configurations, e.g.

sidecars:
  provisioner:
    ...
    args:
      retry-interval-start: 1s
      retry-interval-max: 5m
      timeout: 15s
    ...

  attacher:
    ...
    args:
      retry-interval-start: 1s
      retry-interval-max: 5m
      timeout: 15s
    ...

Describe alternatives you've considered
Our current workaround is to manually patch the ebs-csi-controller deployment after applying the helm chart, which is not a nice workflow.

Additional context
See https://github.com/kubernetes-csi/external-provisioner and https://github.com/kubernetes-csi/external-attacher for a documentation of the available runtime arguments.

@gtxu gtxu added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants