From 5dde9fc3dbf770d31ac3822aa802d52aab3059bd Mon Sep 17 00:00:00 2001
From: s-shiraki <54130718+highpon@users.noreply.github.com>
Date: Tue, 16 Jul 2024 09:39:10 +0900
Subject: [PATCH] feat: Add a column to workload indicating if it is finished
 (#2615)

* feat: Add a column to workload indicating if it is finished

* fix: update helm charts
---
 apis/kueue/v1beta1/workload_types.go                      | 1 +
 charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml  | 4 ++++
 config/components/crd/bases/kueue.x-k8s.io_workloads.yaml | 4 ++++
 3 files changed, 9 insertions(+)

diff --git a/apis/kueue/v1beta1/workload_types.go b/apis/kueue/v1beta1/workload_types.go
index 541a700495..a5c8a6df5e 100644
--- a/apis/kueue/v1beta1/workload_types.go
+++ b/apis/kueue/v1beta1/workload_types.go
@@ -405,6 +405,7 @@ const (
 // +kubebuilder:printcolumn:name="Queue",JSONPath=".spec.queueName",type="string",description="Name of the queue this workload was submitted to"
 // +kubebuilder:printcolumn:name="Reserved in",JSONPath=".status.admission.clusterQueue",type="string",description="Name of the ClusterQueue where the workload is reserving quota"
 // +kubebuilder:printcolumn:name="Admitted",JSONPath=".status.conditions[?(@.type=='Admitted')].status",type="string",description="Admission status"
+// +kubebuilder:printcolumn:name="Finished",JSONPath=".status.conditions[?(@.type=='Finished')].status",type="string",description="Workload finished"
 // +kubebuilder:printcolumn:name="Age",JSONPath=".metadata.creationTimestamp",type="date",description="Time this workload was created"
 // +kubebuilder:resource:shortName={wl}
 
diff --git a/charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml b/charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml
index e107b164b2..fcb07466c8 100644
--- a/charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml
+++ b/charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml
@@ -44,6 +44,10 @@ spec:
       jsonPath: .status.conditions[?(@.type=='Admitted')].status
       name: Admitted
       type: string
+    - description: Workload finished
+      jsonPath: .status.conditions[?(@.type=='Finished')].status
+      name: Finished
+      type: string
     - description: Time this workload was created
       jsonPath: .metadata.creationTimestamp
       name: Age
diff --git a/config/components/crd/bases/kueue.x-k8s.io_workloads.yaml b/config/components/crd/bases/kueue.x-k8s.io_workloads.yaml
index 2bb186bbf1..f7716c3676 100644
--- a/config/components/crd/bases/kueue.x-k8s.io_workloads.yaml
+++ b/config/components/crd/bases/kueue.x-k8s.io_workloads.yaml
@@ -29,6 +29,10 @@ spec:
       jsonPath: .status.conditions[?(@.type=='Admitted')].status
       name: Admitted
       type: string
+    - description: Workload finished
+      jsonPath: .status.conditions[?(@.type=='Finished')].status
+      name: Finished
+      type: string
     - description: Time this workload was created
       jsonPath: .metadata.creationTimestamp
       name: Age