Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus compatible metrics #290

Open
jcpunk opened this issue Jun 20, 2023 · 13 comments
Open

Prometheus compatible metrics #290

jcpunk opened this issue Jun 20, 2023 · 13 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jcpunk
Copy link

jcpunk commented Jun 20, 2023

It would be nice if the pod had a prometheus compatible metrics endpoint (with optional ServiceMonitor from helm).

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2024
@jcpunk
Copy link
Author

jcpunk commented Jan 23, 2024

I'm still interested in this

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 22, 2024
@jcpunk
Copy link
Author

jcpunk commented Feb 22, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2024
@jcpunk
Copy link
Author

jcpunk commented May 22, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2024
@Starttoaster
Copy link

This could be cool, but what metrics would you like to see exported?

@jcpunk
Copy link
Author

jcpunk commented Jun 10, 2024

Perhaps the volumes under management by this tool and any free space per source? Plus the standard CPU/RAM?

@Starttoaster
Copy link

Starttoaster commented Jun 10, 2024

Perhaps the volumes under management by this tool and any free space per source? Plus the standard CPU/RAM?

🤔
This provisioner doesn't currently know or even respect the free space available on the NFS server, so I'm not sure how that would be accomplished.

CPU/RAM sounds more like node_exporter's job than a metrics exporter built into this, to be honest.

Care to give more thoughts for either of those ideas? I'm not a maintainer here to be clear, but I own/maintain a fork of this repository. And was intrigued by the idea of adding metrics to it. I'm just not sure what metrics would really be appropriate for it. For what it's worth, I believe used space in a persistent volume is handled by kubelet's builtin metrics exporter (which is built into kubernetes installations.) And for CPU/RAM metrics of the NFS server, I think you would probably be better suited installing node_exporter on your NFS server. For CPU/RAM metrics of this provisioner, you're actually looking at using CAdvisor's metrics exporter (also built into kubernetes.)

@jcpunk
Copy link
Author

jcpunk commented Jun 10, 2024

I was thinking CPU/RAM usage of the nfs-subdir-external-provisioner process itself.

Maybe how many volumes were created by the provisioner?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2024
@Starttoaster
Copy link

Starttoaster commented Sep 10, 2024

I was thinking CPU/RAM usage of the nfs-subdir-external-provisioner process itself.

This is probably better off being a metric from CAdvisor or kube-state-metrics.

Maybe how many volumes were created by the provisioner?

This metric wouldn't really be valuable to me, personally. It doesn't really tell me anything important about the state of my NFS server. Because number of volumes does not give a sense for disk usage of the NFS server. And for that metric even, I'd probably rather install node_exporter on the NFS server.

Do you actually have an intended use for these metrics already? This strikes me as potentially a nice thing to think about with no identified use case so far though.

@jcpunk
Copy link
Author

jcpunk commented Sep 11, 2024

I don't have a great handle on what would be useful. I mostly just like observational metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants