Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"onDelete: delete" doesn't work if "pathPattern" contains folders #347

Open
uniit opened this issue Aug 5, 2024 · 0 comments
Open

"onDelete: delete" doesn't work if "pathPattern" contains folders #347

uniit opened this issue Aug 5, 2024 · 0 comments

Comments

@uniit
Copy link

uniit commented Aug 5, 2024

Consider the following example:

➜  ~ helm list -n nfs
NAME                           	NAMESPACE	REVISION	UPDATED                                  	STATUS  	CHART                                 	APP VERSION
nfs-subdir-external-provisioner	nfs      	1       	2024-07-24 17:17:58.678176273 +0200 +0200	deployed	nfs-subdir-external-provisioner-4.0.18	4.0.2

Storage Class yaml based on ReadMe:

allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: nfs
parameters:
  onDelete: delete
  pathPattern: /application/dev/${.PVC.annotations.nfs.io/storage-path}
provisioner: k8s-sigs.io/nfs-subdir-external-provisioner
reclaimPolicy: Delete

PVC yaml based on ReadMe:

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    nfs.io/storage-path: app-data
  name: nfs
  namespace: nfs
spec:
  accessModes:
  - ReadWriteMany
  resources:
    requests:
      storage: 5Gi
  storageClassName: nfs

After the PVC removal the nfs provisioner can't find the folder to delete:

W0804 10:43:33.486918       1 provisioner.go:146] path /persistentvolumes/app-data does not exist, deletion skipped

The only way to get OnDelete working is to not use the folder in the path. See an example here.

Question:
Can you please fix that issue or add a note that "onDelete: delete" won't work if "pathPattern" contains folders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant