Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node registration fails if nova AZ value has ' ' #1379

Closed
jichenjc opened this issue Jan 19, 2021 · 3 comments · Fixed by #1381
Closed

Node registration fails if nova AZ value has ' ' #1379

jichenjc opened this issue Jan 19, 2021 · 3 comments · Fixed by #1381
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jichenjc
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

inspired by

#1364

Unable to register node "ocpcic-x45pc-master-0" with API server: Node "ocpcic-x45pc-master-0" is invalid: metadata.labels: Invalid value: "Default Group": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

we suffered above issue with similar pattern, so I think we might consider do same thing to #1364
What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 19, 2021
@jichenjc
Copy link
Contributor Author

/assign

@jichenjc
Copy link
Contributor Author

The issue should be related to label topology.kubernetes.io/zone

@lingxiankong
Copy link
Contributor

As per discussion in #1380, it has been decided we don't solve this issue for now but add a note in the documentation.

We will come back here if we hear more feedback in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
3 participants