Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCCM]use prometheus metrics to replace legacy one? #1534

Closed
jichenjc opened this issue May 17, 2021 · 6 comments
Closed

[OCCM]use prometheus metrics to replace legacy one? #1534

jichenjc opened this issue May 17, 2021 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jichenjc
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/metrics/metrics_reconcile.go#L23
is using legacy metrics, can we move to prometheus (more up-to-date)

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2021
@jichenjc
Copy link
Contributor Author

@seanschneeweiss can you help to provide some comments?

@seanschneeweiss
Copy link
Contributor

I think that most metrics were migrated to legacyregistry as part of the KEP-1209: Metrics Stability Framework.

As far as I understand it, we are already using Prometheus wrapped behind the k8s.io/component-base/metrics package.
Most other cloud providers are also creating metrics similar to us.
E.g. this PR moves from Prometheus to k8s.io/component-base/metrics.

Not sure if we should move "back".

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2021
@ramineni
Copy link
Contributor

ramineni commented Sep 2, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2021
@ramineni
Copy link
Contributor

ramineni commented Sep 2, 2021

@jichenjc Can we close this?

@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 2, 2021

ok, let's close this

@jichenjc jichenjc closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants