[occm] validate flavor name, fallback on flavor id #1364

seanschneeweiss · 2021-01-11T05:55:26Z

What this PR does / why we need it:
The node.kubernetes.io/instance-type label accepts alphanumeric
characters, '-', '_', and '.' only. If the flavor name contains
invalid characters, the flavor id is used instead.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

This addresses the issue mentioned in #1213 (comment).

error syncing 'blue-master-1': Node "blue-master-1" is invalid: metadata.labels: Invalid value: "Small HD 4GB": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?'), requeuing

Release note:

NONE

_{Sean Schneeweiss sean.schneeweiss@daimler.com, Daimler TSS GmbH, legal info/Impressum}

k8s-ci-robot · 2021-01-11T05:55:34Z

Hi @seanschneeweiss. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-01-11T05:59:15Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 3m 24s

theopenlab-ci · 2021-01-11T05:59:43Z

Build succeeded.

cloud-provider-openstack-unittest : SUCCESS in 3m 50s

theopenlab-ci · 2021-01-11T06:09:42Z

Build failed.

cloud-provider-openstack-acceptance-test-lb-octavia : FAILURE in 13m 08s

theopenlab-ci · 2021-01-11T06:12:59Z

Build succeeded.

cloud-provider-openstack-acceptance-test-csi-cinder : SUCCESS in 12m 12s

theopenlab-ci · 2021-01-11T06:52:19Z

Build succeeded.

cloud-provider-openstack-acceptance-test-csi-manila : SUCCESS in 56m 09s

theopenlab-ci · 2021-01-11T08:43:57Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance : SUCCESS in 2h 28m 20s

theopenlab-ci · 2021-01-11T08:49:54Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 : SUCCESS in 1h 18m 39s

jichenjc · 2021-01-12T00:59:50Z

/ok-to-test

jichenjc · 2021-01-12T01:01:14Z

/lgtm

seanschneeweiss · 2021-01-12T08:30:41Z

/retest

theopenlab-ci · 2021-01-12T08:35:00Z

Build succeeded.

cloud-provider-openstack-unittest : SUCCESS in 3m 57s

theopenlab-ci · 2021-01-12T08:36:17Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 3m 34s

theopenlab-ci · 2021-01-12T08:44:32Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-cinder : POST_FAILURE in 12m 19s

theopenlab-ci · 2021-01-12T08:47:59Z

Build succeeded.

cloud-provider-openstack-acceptance-test-lb-octavia : SUCCESS in 16m 45s

theopenlab-ci · 2021-01-12T09:20:58Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 47m 35s

theopenlab-ci · 2021-01-12T10:40:46Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 : SUCCESS in 1h 33m 01s

theopenlab-ci · 2021-01-12T10:58:58Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance : SUCCESS in 2h 23m 04s

seanschneeweiss · 2021-01-12T23:22:03Z

/test cloud-provider-openstack-acceptance-test-csi-manila

theopenlab-ci · 2021-02-08T11:09:35Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 2m 44s

theopenlab-ci · 2021-02-08T11:10:17Z

Build succeeded.

cloud-provider-openstack-unittest : SUCCESS in 3m 13s

theopenlab-ci · 2021-02-08T11:19:51Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 11m 49s

theopenlab-ci · 2021-02-08T11:20:05Z

Build failed.

cloud-provider-openstack-acceptance-test-lb-octavia : FAILURE in 12m 59s

theopenlab-ci · 2021-02-08T11:21:20Z

Build succeeded.

cloud-provider-openstack-acceptance-test-csi-cinder : SUCCESS in 13m 41s

theopenlab-ci · 2021-02-08T13:35:12Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance : SUCCESS in 2h 23m 43s

theopenlab-ci · 2021-02-08T14:34:39Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19 : SUCCESS in 2h 11m 56s

theopenlab-ci · 2021-02-08T14:44:24Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20 : SUCCESS in 2h 23m 24s

theopenlab-ci · 2021-02-08T15:04:53Z

Build succeeded.

cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18 : SUCCESS in 1h 28m 25s

lingxiankong · 2021-02-09T03:31:26Z

/test cloud-provider-openstack-acceptance-test-lb-octavia

k8s-ci-robot · 2021-02-09T03:31:28Z

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-02-09T03:46:07Z

Build failed.

cloud-provider-openstack-acceptance-test-lb-octavia : FAILURE in 12m 32s

lingxiankong · 2021-02-09T09:02:15Z

/test cloud-provider-openstack-acceptance-test-lb-octavia

k8s-ci-robot · 2021-02-09T09:02:17Z

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lingxiankong · 2021-02-09T09:02:31Z

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

k8s-ci-robot · 2021-02-09T09:02:34Z

@lingxiankong: Overrode contexts on behalf of lingxiankong: openlab/cloud-provider-openstack-acceptance-test-csi-manila

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-02-09T09:18:23Z

Build succeeded.

cloud-provider-openstack-acceptance-test-lb-octavia : SUCCESS in 15m 25s

ramineni · 2021-02-09T09:54:31Z

/lgtm

ramineni · 2021-02-09T09:55:08Z

@seanschneeweiss lets backport this to 1.20 as well

seanschneeweiss · 2021-02-09T15:42:51Z

@seanschneeweiss lets backport this to 1.20 as well

Please see #1402

lingxiankong · 2021-02-10T07:28:09Z

/approve

k8s-ci-robot · 2021-02-10T07:28:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/cloudprovider/providers/openstack/OWNERS~~ [lingxiankong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The node.kubernetes.io/instance-type label accepts alphanumeric characters, '-', '_', and '.' only. If the flavor name contains invalid characters, the flavor id is used instead. Signed-off-by: Sean Schneeweiss <sean.schneeweiss@daimler.com>

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 11, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 11, 2021

k8s-ci-robot requested review from anguslees and FengyunPan2 January 11, 2021 05:55

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2021

seanschneeweiss mentioned this pull request Jan 11, 2021

[occm] lookup flavor name if only id is provided #1213

Merged

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2021

k8s-ci-robot assigned jichenjc Jan 12, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021

seanschneeweiss force-pushed the whitespace-flavor-fix branch from dd985dd to 212ea15 Compare February 8, 2021 11:03

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021

seanschneeweiss mentioned this pull request Feb 9, 2021

[occm] validate flavor name, fallback on flavor id (release-1.20) #1402

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021

k8s-ci-robot merged commit 7642d71 into kubernetes:master Feb 10, 2021

This was referenced May 18, 2021

REQUEST: New membership for seanschneeweiss kubernetes/org#2719

Closed

REQUEST: New membership for seanschneeweiss kubernetes/org#2725

Closed

[occm] validate flavor name, fallback on flavor id #1364

[occm] validate flavor name, fallback on flavor id #1364

Conversation

seanschneeweiss commented Jan 11, 2021 • edited Loading

k8s-ci-robot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

theopenlab-ci bot commented Jan 11, 2021

jichenjc commented Jan 12, 2021

jichenjc commented Jan 12, 2021

seanschneeweiss commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

theopenlab-ci bot commented Jan 12, 2021

seanschneeweiss commented Jan 12, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

theopenlab-ci bot commented Feb 8, 2021

lingxiankong commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

theopenlab-ci bot commented Feb 9, 2021

lingxiankong commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

lingxiankong commented Feb 9, 2021

k8s-ci-robot commented Feb 9, 2021

theopenlab-ci bot commented Feb 9, 2021

ramineni commented Feb 9, 2021

ramineni commented Feb 9, 2021

seanschneeweiss commented Feb 9, 2021

lingxiankong commented Feb 10, 2021

k8s-ci-robot commented Feb 10, 2021

seanschneeweiss commented Jan 11, 2021 •

edited

Loading