From 2fd09512fae246e8822f55755439785e0afdfae2 Mon Sep 17 00:00:00 2001 From: Harry Zhang Date: Tue, 12 Sep 2017 20:25:52 +0800 Subject: [PATCH] Clarify taint key name convension --- contributors/devel/api-conventions.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contributors/devel/api-conventions.md b/contributors/devel/api-conventions.md index e2c7bab6766..5800d989ef8 100644 --- a/contributors/devel/api-conventions.md +++ b/contributors/devel/api-conventions.md @@ -1228,10 +1228,11 @@ policy field. The "name" portion of the annotation should follow the below conventions for annotations. When an annotation gets promoted to a field, the name transformation should then be mechanical: `foo-bar` becomes `fooBar`. -Other advice regarding use of labels, annotations, and other generic map keys by +Other advice regarding use of labels, annotations, taints, and other generic map keys by Kubernetes components and tools: - - Key names should be all lowercase, with words separated by dashes, such as -`desired-replicas` + - Key names should be all lowercase, with words separated by dashes instead of camelCase + - For instance, prefer `foo.kubernetes.io/foo-bar over` `foo.kubernetes.io/fooBar`, prefer + `desired-replicas` over `DesiredReplicas` - Prefix the key with `kubernetes.io/` or `foo.kubernetes.io/`, preferably the latter if the label/annotation is specific to `foo` - For instance, prefer `service-account.kubernetes.io/name` over @@ -1241,7 +1242,6 @@ the resource doesn't need to know about, experimental fields that aren't intended to be generally used API fields, etc. Beware that annotations aren't automatically handled by the API conversion machinery. - ## WebSockets and SPDY Some of the API operations exposed by Kubernetes involve transfer of binary