Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to setup minReadySeconds/terminationGracePeriodSeconds with NEG? #1072

Closed
axot opened this issue Apr 10, 2020 · 3 comments
Closed

How to setup minReadySeconds/terminationGracePeriodSeconds with NEG? #1072

axot opened this issue Apr 10, 2020 · 3 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@axot
Copy link

axot commented Apr 10, 2020

According to the document,

You should configure your workloads' minReadySeconds and terminationGracePeriodSeconds values to be 60 seconds or higher to ensure that the service is not disrupted due to workload rollouts.

In my test, even use a much less minReadySeconds/terminationGracePeriodSeconds, there are no impact at the view of response latency. Use minReadySeconds/terminationGracePeriodSeconds:60 will slow down our development deploy progress. How to tuning the value of minReadySeconds? Why not 10 or 20 but 60 seconds?

Thanks,

@rramkumar1
Copy link
Contributor

/assign @freehan

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2020
@freehan
Copy link
Contributor

freehan commented Jul 9, 2020

Please check with the note on the top of this section: https://cloud.google.com/kubernetes-engine/docs/how-to/container-native-load-balancing#align_rollouts

For versions with pod readiness feedback enabled. minReadySeconds is no longer needed. But terminationGracePeriodSeconds is still required if the rolling update needs to be seamless.

@freehan freehan closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants