Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align node filtering with service controller #292

Closed
octplane opened this issue Jun 1, 2018 · 1 comment
Closed

Align node filtering with service controller #292

octplane opened this issue Jun 1, 2018 · 1 comment
Assignees
@rramkumar1
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@octplane
Copy link

octplane commented Jun 1, 2018

Hello,

Would there be any interest in aligning the current node selection currently done when building the Instances Group:

https://github.com/kubernetes/ingress-gce/blob/master/pkg/controller/utils.go#L202-L215

  • code ignores Unschedulable nodes,

to the one in k8s:

https://github.com/kubernetes/kubernetes/blob/97fdf8ac70dfdaf07074dee6b6cb345be71e96ec/pkg/controller/service/service_controller.go#L585-L619

code ignores:

  • Unschedulable nodes
  • Nodes with the label node-role.kubernetes.io/master
  • Nodes with the label alpha.service-controller.kubernetes.io/exclude-balancer

More generally, it might be nice to allow to blacklist labels via configuration.
@lbernail lbernail mentioned this issue Jun 1, 2018
Closed
@nicksardo nicksardo changed the title Node selection to include in Instance Groups Align node filtering with service controller Jun 5, 2018
@lbernail lbernail mentioned this issue Jun 27, 2018
Merged
@nicksardo nicksardo added the kind/bug Categorizes issue or PR as related to a bug. label Jul 16, 2018
@rramkumar1
Copy link
Contributor

Fixed by #370
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rramkumar1 rramkumar1

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@octplane @nicksardo @k8s-ci-robot @rramkumar1