Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Configuration via ConfigMap #593

Closed
olib963 opened this issue Dec 28, 2018 · 2 comments
Closed

Feature Request - Configuration via ConfigMap #593

olib963 opened this issue Dec 28, 2018 · 2 comments

Comments

@olib963
Copy link

olib963 commented Dec 28, 2018

I would like to be able to inject the ingress configuration that is usually gathered from static annotations instead through a configmap. I am happy to look into implementing this myself if this would be an acceptable addition. I was hoping in the ingress I could write:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: my-ingress
  annotations:
    kubernetes.io/ingress.class: "gce"
spec:
  confgMapName: ingress
  ...

where the configmap is

apiVersion: v1
kind: ConfigMap
metadata:
  name: ingress
data:
    kubernetes.io/ingress.global-static-ip-name: "my-ip-name"
    kubernetes.io/ingress.allow-http: "false"

This would allow me to reuse the same declarative Gitops repo and simply terraform a new cluster and static IP, then have terraform inject the IP name as config.

@rramkumar1
Copy link
Contributor

@olib963 I'm not sure your proposal makes sense. IIUC, this would require a change to the Ingress API to support the "configMapName" field? This is definitely a non-starter.

@olib963
Copy link
Author

olib963 commented Jan 11, 2019

@rramkumar1 That's ok, we could have added this functionality in an annotation instead of in the spec field e.g. gce.ingress/configmap: ingress. I have decided to go with the NGINX ingress instead, it seems a little more mature and configurable and isn't leaking resources as we rebuild. Thank you for the reply :D

@olib963 olib963 closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants