Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEG controller should create NEG for default backend when enabled #767

Closed
freehan opened this issue Jun 11, 2019 · 4 comments
Closed

NEG controller should create NEG for default backend when enabled #767

freehan opened this issue Jun 11, 2019 · 4 comments
Assignees
@freehan
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@freehan
Copy link
Contributor

freehan commented Jun 11, 2019 •
edited
Loading

NEG controller currently ignores default backend service even it has NEG enabled. This is because default backend service is not explicitly referenced in the ingress spec.

https://github.com/kubernetes/ingress-gce/blob/master/pkg/neg/controller.go#L309
@freehan freehan added the kind/bug Categorizes issue or PR as related to a bug. label Jun 11, 2019
@freehan freehan self-assigned this Jun 11, 2019
@freehan freehan mentioned this issue Jun 12, 2019
Closed
5 tasks
@spencerhance spencerhance mentioned this issue Jul 19, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2019
@freehan
Copy link
Contributor Author

freehan commented Sep 20, 2019

/close as #789 is merged

@freehan freehan closed this as completed Sep 20, 2019
@RafiGreenberg
Copy link

@freehan Just curious - does #789 only apply to ILB?

It seems that all our NEG-enabled services create default backends as instance groups.

image

@spencerhance
Copy link
Contributor

@rafi-greenberg right now this only applies to ILB. @freehan are we planning on supporting this for ELB with neg default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freehan freehan

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@freehan @RafiGreenberg @spencerhance @k8s-ci-robot @fejta-bot