Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Incorrect ingress key function is being used #879

Closed
skmatti opened this issue Oct 1, 2019 · 1 comment · Fixed by #881
Closed

Bug: Incorrect ingress key function is being used #879

skmatti opened this issue Oct 1, 2019 · 1 comment · Fixed by #881

Comments

@skmatti
Copy link
Contributor

skmatti commented Oct 1, 2019

Refer: #825 (comment). The ingress key generated by IngressKeyFunc does not match the key generated in Ingress store in some special cases (when namespace is empty). IngressKeyFunc should be replaced by this. This function is used for GC'ing loadbalancers, so this may cause some loadbalancers to be deleted incorrectly.
@skmatti
Copy link
Contributor Author

skmatti commented Oct 1, 2019

In general this should not cause a bug if ingress has a valid object meta defined here and a non-empty namespace. So, this would not cause any problems with valid ingresses in production.

@skmatti skmatti mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BugFix: Update ingress key function used for GC skmatti/ingress-gce
1 participant
@skmatti