Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified DummyLSU #427

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Simplified DummyLSU #427

merged 2 commits into from
Jul 5, 2023

Conversation

tilk
Copy link
Member

@tilk tilk commented Jul 4, 2023 •
edited
Loading

You wanted a simplified DummyLSU? You've got a simplified DummyLSU. Now with only two states in the FSM!

This also slightly increases IPC and reduces the core size.

@tilk tilk added the refactor Doesn't change functionality, but makes stuff nicer label Jul 4, 2023
lekcyjna123
lekcyjna123 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@lekcyjna123 lekcyjna123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks much better.

piotro888
piotro888 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@piotro888 piotro888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler LSU - simple approve

Very nice changes.
IPC results are interesting, maybe running operations immediately was not that great idea (this time probably because on jump mispredicts after LOAD). Or is that because of other simplifications in FSM?

@tilk tilk merged commit df6653b into master Jul 5, 2023
10 checks passed
@tilk tilk deleted the tilk/dummylsu-simplified branch July 5, 2023 08:04
github-actions bot pushed a commit that referenced this pull request Jul 5, 2023
@tilk
Simplified DummyLSU (#427)
3b1adbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotro888 piotro888 piotro888 approved these changes

@lekcyjna123 lekcyjna123 lekcyjna123 approved these changes

Assignees
No one assigned
Labels
refactor Doesn't change functionality, but makes stuff nicer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilk @piotro888 @lekcyjna123