Update python to 3.11 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 8, 2023 15:30
piotro888
reviewed
Oct 14, 2023
Arusekk
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Should work fine :) especially with #384 (comment) out of the way.
| - name: Install dependencies | ||
| run: | | ||
| python3 -m venv venv |
There was a problem hiding this comment.
setup-python should make python enough; also, no need for venv I think, as the python that has been set up has one by default already (or is it the --break-system-packages thing?)
Suggested change
| python3 -m venv venv | |
| python -m venv venv |
or even
Suggested change
| python3 -m venv venv |
| python3 -m pip install --upgrade pip | ||
| pip3 install -r requirements-dev.txt | ||
| python3 -m pip install -r requirements-dev.txt |
There was a problem hiding this comment.
This should be enough with setup-python (especially when using venv, but even without it)
Suggested change
| python3 -m pip install -r requirements-dev.txt | |
| pip install -r requirements-dev.txt |
|
|
||
| RUN apt-get update && \ | ||
| DEBIAN_FRONTEND=noninteractive \ | ||
| apt-get install -y --no-install-recommends \ | ||
| python3.10 python3-pip git yosys \ | ||
| python3.11 python3-pip git yosys lsb-release \ |
There was a problem hiding this comment.
Why is this needed? Would love to see some explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed in #472 we need to update python to 3.11 to be allowed to inherit
__init__inProtocol. This pull request update docker files, docker images and documentation.It introduced venv to jobs which uses custom dockers because in python 3.11 installing packages system wide is disabled by default and
setup-pythondon't work with custom docker images. There are reported issues (eg. actions/setup-python#719), but they aren't solved.I also updated
pip3 install ...topython3 -m pip install ...to always use the same python version (setup-python don't configure pip so it is used system wide instead of uploaded by setup-python).