Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks needed in snippet preview and <pre> blocks #1

Closed
terminalmage opened this issue Aug 10, 2015 · 7 comments
Closed

Tweaks needed in snippet preview and <pre> blocks #1

terminalmage opened this issue Aug 10, 2015 · 7 comments
Labels

Comments

@terminalmage
Copy link
Contributor

The blocks contained within div.snippet_preview DIVs look like they still need some love. span.sssh-property is still black-on-black.

To reproduce, create a code snippet with Python highlighting and dump this code into it:

>>> import timeit
>>> t1 = timeit.Timer('"{0}/{1}".format(x, y)', 'x = "foo"; y = "bar"')
>>> t2 = timeit.Timer('"/".join((x, y))', 'x = "foo"; y = "bar"')
>>> t1.repeat()
[0.4785940647125244, 0.43045902252197266, 0.4402921199798584]
>>> t2.repeat()
[0.31827497482299805, 0.2677180767059326, 0.2675449848175049]
>>>

The "Timer" text will be invisible. This is similar to a fix you recently did for syntax highlighting, just needs to be made here as well.

Also, pre.special_formatting (triple-backtick-enclosed blocks of text) displays mentions (span.mention) as grey-on-magenta.

Thanks!

@laCour
Copy link
Owner

laCour commented Aug 10, 2015

Thanks!

I'm unable to replicate the second issue you mentioned though. Mentions in blockquotes and code blocks are not wrapped in span.mention for me.

@terminalmage
Copy link
Contributor Author

Here's what I'm seeing:

slack_mention

Weirdly enough, span.mention has a background attribute of #61485e, which should be correct... But instead I'm seeing magenta. CSS is not my strong suit though, so perhaps some other CSS code is interacting to produce that result.

@laCour
Copy link
Owner

laCour commented Aug 10, 2015

Ah, alright. This is due to how I hackishly styled code blocks and blockquotes. Currently the entire blocks have filters applied to them which invert their colors and rotate the hue (this is why the span.mention element has the correct color, but it is not being displayed as such). This is part of _hacks.scss.

Later today I'll definitely properly override these styles. This is easier with the newer Sass layout; my hackish filter method of doing this is a remnant from before.

@terminalmage
Copy link
Contributor Author

OK, I'm seeing the below in normal mentions too, don't know if it's related. The username should show as white here.

slack_mention

@terminalmage
Copy link
Contributor Author

And the plot thickens with that last one. Mentions without a leading "@" look fine, slack must just be using a different span class for mentions with the leading "@".

@laCour
Copy link
Owner

laCour commented Aug 10, 2015

I noticed that but couldn't figure out what caused the difference--thanks!

@terminalmage
Copy link
Contributor Author

No prob! Just noticed this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants