Help testing middleware

[raphael]

echo currently makes it hard/impossible to initialize a context outside of an actual HTTP request handling (the "response" field is private for example). This makes testing echo middleware tricky as one cannot just mock a context. It would be good if echo exposed a way to create arbitrary contexts. To make things more concrete here is an example of what I'm trying to achieve:

// Create dummy echo.Context with request for tests
// Note: echo makes it impossible to initialize the context response :(
func dummyContext() *echo.Context {
    req, _ := http.NewRequest("POST", "http://example.com", strings.NewReader("foo"))
    ctx := echo.Context{Request: req}
    ctx.String(200, "ok") // BLOWS UP because "response" not initialized
    return &ctx
}

[vishr]

Let me know if this helps.

[raphael]

Thanks for the quick response! Something else that doesn't work though is then trying to use c.Set() and c.Get() in tests as it tries to write to a nil hashmap.

[vishr]

I think providing a NewContext function should solve this?

[raphael]

Yup that would be perfect!

[vishr]

Please verify b416efc

[raphael]

Thank you this helps. One last thing that is still not possible is to specify the response status and size because they are private fields of the Response struct. I'm using these fields in the middleware so being able to set them would help testing.

[vishr]

Check https://github.com/labstack/echo/blob/master/context_test.go#L26. WriteHeader and Write should set status and size on response.

[raphael]

Yup calling c.Response.Write() worked, thanks! in case you're curious: https://github.com/rightscale/go_middleware

[vishr]

Great!