Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Healthcheck Testing/Blank dbname/user Testing #44

Open
reynoldsalec opened this issue Mar 11, 2024 · 0 comments
Open

Better Healthcheck Testing/Blank dbname/user Testing #44

reynoldsalec opened this issue Mar 11, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@reynoldsalec
Copy link
Sponsor Member

reynoldsalec commented Mar 11, 2024

We just implemented a fix to handle situations where the user specifies blank dbname/password/username for the db config. Ex:

services:
  database:
    type: mariadb
      creds:
        user: customusername
        password:
        database: customdbname

The fix: 017dba9

I put in a "test case" in the custom example to make sure a blank password wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank user or database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.

@reynoldsalec reynoldsalec added the good first issue Good for newcomers label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

No branches or pull requests

1 participant