Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi database test suite #47428

Closed
Guilhem-DELAITRE opened this issue Jun 13, 2023 · 1 comment
Closed

Multi database test suite #47428

Guilhem-DELAITRE opened this issue Jun 13, 2023 · 1 comment

Comments

@Guilhem-DELAITRE
Copy link
Contributor

Guilhem-DELAITRE commented Jun 13, 2023 •
edited
Loading

Laravel Version

10.x

PHP Version

8.1.x

Database Driver & Version

No response

Description

I do not understand why in the checks that are done on multiple database system by github, the test suite being tested is only tests/Integration/Database, and for example why is tests/Database not included in those.

This caused (with the help of an error on my part of course) the problems described in #46309 subsequently to its merge.

Steps To Reproduce

Create a PR, only some subset of databases tests are executed on multiple databases
@driesvints
Copy link
Member

Thanks but this doesn't seems like a bug report. Feel free to send in a PR if you want to change something to the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driesvints @Guilhem-DELAITRE