Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to a member function setTimezone() on null for favicon.ico #47600

Closed
pascalvgemert opened this issue Jun 28, 2023 · 1 comment
Closed

Call to a member function setTimezone() on null for favicon.ico #47600

pascalvgemert opened this issue Jun 28, 2023 · 1 comment

Comments

@pascalvgemert
Copy link

Laravel Version

10.14.0

PHP Version

8.2

Database Driver & Version

MySQL 8

Description

The following feature has a breaking change for Vapor:
#47567

When the request is a favicon.ico the pipeline in vendor/laravel/vapor-core/src/Runtime/HttpKernel::sendRequest will exit and call the terminate() method below. This will try to set a timezone on the requestStartedAt which is still null because the request hasn't been handled yet. This causes a 500 error at the moment.

Possible solution

Easy fix would be to add a null safe operator I guess.

image

Temporary solution:

Publish vapor config and add 'redirect_favicon' => false,

Steps To Reproduce

See image in description.

Vapor request to example-domain.com/favicon.ico which wants to redirect.

@timacdonald
Copy link
Member

Duplicate of #47591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants