Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regression on hasRole #4

Merged
merged 1 commit into from
Jul 22, 2019
Merged

fix: Regression on hasRole #4

merged 1 commit into from
Jul 22, 2019

Conversation

nmfzone
Copy link
Contributor

@nmfzone nmfzone commented Jul 22, 2019

hasRole tidak akan berjalan semestinya ketika developer menggunakan fitur checkAll.

Mungkin akan menimbulkan masalah di APP yang sudah berjalan di production. Possible breaking changes.

`hasRole` tidak akan berjalan semestinya ketika developer menggunakan fitur `checkAll`.
@uyab
Copy link
Contributor

uyab commented Jul 22, 2019

Contoh kasusnya seperti apa @nmfzone ?

@nmfzone
Copy link
Contributor Author

nmfzone commented Jul 22, 2019

@uyab Contoh kasusnya ketika array multidimensi. Karena hasRole ini rekursif, harusnya bisa menghandle multidimensi.

$user->hasRole([['Superadmin', 'Admin']], true);

@uyab
Copy link
Contributor

uyab commented Jul 22, 2019

I see, tidak pernah terpikirkan akan ada yang masukin multidimensi array as parameter 👍

@uyab uyab merged commit 832c48e into laravolt:master Jul 22, 2019
@nmfzone
Copy link
Contributor Author

nmfzone commented Jul 22, 2019

Mantaaapp 🔥

@nmfzone nmfzone deleted the patch-1 branch July 23, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants