Corrected dimension of X in Adaptors.Outlet

This corrects the dimension which caused the model to not translate in some tools if water is used (with nX=1).
lbl-srg · Jun 29, 2023 · aec9da4 · aec9da4
1 parent a6fa250
commit aec9da4
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/Buildings/Fluid/FMI/Adaptors/Outlet.mo b/Buildings/Fluid/FMI/Adaptors/Outlet.mo
@@ -85,7 +85,7 @@ equation
   bacPro_internal.T  = Medium.temperature_phX(
     p = p_in_internal,
     h = port_a.h_outflow,
-    X = port_a.Xi_outflow);
+    X = cat(1, port_a.Xi_outflow, {1-sum(port_a.Xi_outflow)}));
   bacPro_internal.C  = port_a.C_outflow;
 
   // Conditional connectors for pressure
@@ -153,6 +153,11 @@ for how to use this model.
 </html>", revisions="<html>
 <ul>
 <li>
+June 29, 2023, by Michael Wetter:<br/>
+Corrected dimension of <code>X</code> in function call.<br/>
+See <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1768\">#1768</a>.
+</li>
+<li>
 January 18, 2019, by Jianjun Hu:<br/>
 Limited the media choice to moist air and water.
 See <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1050\">#1050</a>.

diff --git a/Buildings/Utilities/Math/Functions/bicubic.mo b/Buildings/Utilities/Math/Functions/bicubic.mo
@@ -20,7 +20,9 @@ algorithm
             + a[10] * x1 * x2Sq;
 
   annotation (smoothOrder=999, Documentation(info="<html>
+<p>
 This function computes
+</p>
 <p align=\"center\" style=\"font-style:italic;\">
  y = a<sub>1</sub>
     + a<sub>2</sub>  x<sub>1</sub> + a<sub>3</sub>  x<sub>1</sub><sup>2</sup>
@@ -34,6 +36,10 @@ This function computes
 </html>", revisions="<html>
 <ul>
 <li>
+June 25, 2023, by Michael Wetter:<br/>
+Corrected html formatting.
+</li>
+<li>
 Sep 17, 2010 by Michael Wetter:<br/>
 First implementation.
 </li>

diff --git a/Buildings/package.mo b/Buildings/package.mo
@@ -421,6 +421,16 @@ that do <b style=\"color:red\">not</b> lead to wrong simulation results, e.g.,
 units are wrong or errors in documentation):
 </p>
 <table class=\"releaseTable\" summary=\"summary\" border=\"1\" cellspacing=\"0\" cellpadding=\"2\" style=\"border-collapse:collapse;\">
+<tr><td colspan=\"2\"><b>Buildings.Fluid.FMI</b>
+  </td>
+</tr>
+<tr><td valign=\"top\">Buildings.Fluid.FMI.Adaptors.Outlet
+  </td>
+  <td valign=\"top\">Corrected dimension of <code>X</code> in function call, which caused the model to not translate with some tools
+                     if the media has only one component such as water.<br/>
+                     <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1768\">IBPSA, #1768</a>.
+  </td>
+</tr>
 <tr><td colspan=\"2\"><b>Buildings.Fluid.HeatExchangers</b>
   </td>
 </tr>