Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated existing BESTEST cases and added new cases #3032

Merged
merged 32 commits into from
May 27, 2022
Merged

updated existing BESTEST cases and added new cases #3032

merged 32 commits into from
May 27, 2022

Conversation

JayHuLBL
Copy link
Contributor

This closes #3005 and #3026.

@JayHuLBL JayHuLBL requested a review from mwetter May 23, 2022 21:52
mwetter
mwetter requested changes May 24, 2022
View reviewed changes
Copy link
Member

@mwetter mwetter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The bar plots of the free floating case look wrong. They plot case 960, which has very different results. Shouldn't the plot be for 960FF?
  • Can you make a PR for CenterOfGlass.mo against the maint_8.1.x branch
  • Update the reference results that fail the CI tests.

@JayHuLBL
Copy link
Contributor Author

@mwetter

  • The bar plots for the free floating case indeed have wrong results. Case 960 has two zones, back zone and sun space zone. The back zone is conditioned with HVAC while the sun space is free floating. In previous plot, the back zone temperature was plot but we in fact should plot the temperature in the sun space. The error has been corrected.
  • Made PR for the changes in CenterOfGlass.mo against branch maint_8.1.x
  • Updated the reference results for the classes that uses the Case600 as the base class. The unit tests have been done with the Dymola version 2022x. (Note that the results are different when run with version 2022.).

mwetter
mwetter approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayHuLBL : Thanks for the validation, I will merge when the tests pass.

@mwetter mwetter enabled auto-merge (squash) May 24, 2022 21:45
@mwetter
Corrected air pressure to be the same as in weather data file
87dea27 
This required adding a small flow resistance to decouple the pressure boundary condition from the room model. Annual cooling for Case 900 changes by 4%.
@mwetter mwetter disabled auto-merge May 24, 2022 23:14
@mwetter mwetter merged commit 4f21177 into master May 27, 2022
@mwetter mwetter deleted the issue3005_BESTEST_update branch May 27, 2022 12:18
mildwall added a commit to mildwall/modelica-buildings that referenced this pull request Sep 16, 2024
@mildwall @mwetter
updated existing BESTEST cases and added new cases (lbl-srg#3032)
26fd30f 
* updated to latest BESTEST

* added release note and revision note for the CenterOfGlass class

* Corrected air pressure to be the same as in weather data file

This required adding a small flow resistance to decouple the pressure boundary condition from the room model. Annual cooling for Case 900 changes by 4%.

* Added models to exclude list

Co-authored-by: Michael Wetter <mwetter@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter mwetter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update BESTEST cases based on the changes in ASHRAE 140 version 2020
2 participants
@JayHuLBL @mwetter