Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BESTEST test acceptance criteria limits #3401

Merged
merged 31 commits into from
Jul 11, 2023
Merged

Add BESTEST test acceptance criteria limits #3401

merged 31 commits into from
Jul 11, 2023

Conversation

JayHuLBL
Copy link
Contributor

This closes #3396.

  • added the BESTEST test acceptance criteria limits to ASHRAE140_data.dat file
  • added the limits to the userGuide. This includes updating the script for generating the tables in the documentation.
  • added the plots to the non-free floating cases in package Cases6xx and Cases9xx

@JayHuLBL JayHuLBL requested a review from mwetter May 15, 2023 17:58
@JayHuLBL JayHuLBL self-assigned this May 15, 2023
mwetter
mwetter requested changes May 17, 2023
View reviewed changes
Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments.

@JayHuLBL
Copy link
Contributor Author

@mwetter Your comments have been addressed.

@mwetter
Copy link
Member

mwetter commented May 24, 2023

@JayHuLBL : Would Case980 pass if the tolerance is increased, or the number of elements for the heat transfer discretization is increased?

@JayHuLBL
Copy link
Contributor Author

@mwetter

Since your last review, I changed the number of state as:
Screenshot 2023-06-22 at 3 40 19 PM
and tested the change of the tolerance for the Case980, 1e-5, 1e-6, or 1e-7.

The annual cooling load of Case980 (3.423 MWh) is still lower than the criteria ([3.52, 4.49]MWh), although it is higher than previously (3.404 MWh, commit 919d88a).

@JayHuLBL
Copy link
Contributor Author

@mwetter I changed the code and now there are other three tools (BSIMAC, DeST and TRNSYS) have the flagged results in various cases.

I have also tested different PID control gains but the impacts are minor. I would suggest keeping the results as it is.

@mwetter mwetter enabled auto-merge (squash) July 11, 2023 21:47
@mwetter mwetter merged commit 5c00f9d into master Jul 11, 2023
2 checks passed
@mwetter mwetter deleted the issue3396_add_BESTEST_criteria branch July 11, 2023 21:48
mildwall added a commit to mildwall/modelica-buildings that referenced this pull request Sep 16, 2024
@mildwall @mwetter
Add BESTEST test acceptance criteria limits (lbl-srg#3401)
f1d9c99 
* adding the limits to the userGuide

* flagged all the results

---------

Co-authored-by: Michael Wetter <mwetter@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter mwetter approved these changes

Assignees

@JayHuLBL JayHuLBL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test acceptance criteria to the BESTEST cases
2 participants
@JayHuLBL @mwetter